feat(cubesql): Push Limit-Sort down Projection #9776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9776 +/- ##
==========================================
+ Coverage 84.28% 84.32% +0.04%
==========================================
Files 233 233
Lines 86704 86938 +234
==========================================
+ Hits 73075 73309 +234
Misses 13629 13629
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Alex Qyoun-ae <[email protected]>
MazterQyou
force-pushed
the
cubesql/push-down-limit-sort-projection
branch
from
d16cd71 to
630290a
Compare
Frank-TXS
pushed a commit
to Helge-TXS/cube
that referenced
this pull request
Aug 5, 2025
igorlukanin
pushed a commit
that referenced
this pull request
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
This PR adds Limit-Sort to Projection push down rule which helps queries that could be planned as CubeScan but contain complex Projections that cannot be pushed down, and as such get planned using SQL push down.
It also fixes an issue with Limit-Sort combinations not being prioritized lower than SQL push down when Limit-Sort is not at the top of the plan.
Related test is included.